sts: add STS_UNREACHABLE_DEFAULT_CASE()

This commit is contained in:
Michael Scire 2019-09-28 15:13:20 -07:00
parent b52d630cf0
commit 5c610a2225
8 changed files with 29 additions and 46 deletions

View File

@ -21,6 +21,8 @@
#define STS_ASSERT(expr) do { if (!(expr)) { std::abort(); } } while (0) #define STS_ASSERT(expr) do { if (!(expr)) { std::abort(); } } while (0)
#define STS_UNREACHABLE_DEFAULT_CASE() default: std::abort()
#define NON_COPYABLE(cls) \ #define NON_COPYABLE(cls) \
cls(const cls&) = delete; \ cls(const cls&) = delete; \
cls& operator=(const cls&) = delete cls& operator=(const cls&) = delete

View File

@ -77,9 +77,7 @@ static void _CacheValues(void)
case AtmosphereTargetFirmware_900: case AtmosphereTargetFirmware_900:
g_firmware_version = FirmwareVersion_900; g_firmware_version = FirmwareVersion_900;
break; break;
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
break;
} }
__atomic_store_n(&g_HasCached, true, __ATOMIC_SEQ_CST); __atomic_store_n(&g_HasCached, true, __ATOMIC_SEQ_CST);
@ -145,9 +143,7 @@ void SetFirmwareVersionForLibnx() {
minor = 0; minor = 0;
micro = 0; micro = 0;
break; break;
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
break;
} }
hosversionSet(MAKEHOSVERSION(major, minor, micro)); hosversionSet(MAKEHOSVERSION(major, minor, micro));
} }

View File

@ -116,8 +116,7 @@ namespace sts::os {
case SystemEventState::InterProcessEvent: case SystemEventState::InterProcessEvent:
this->GetInterProcessEvent().~InterProcessEvent(); this->GetInterProcessEvent().~InterProcessEvent();
break; break;
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
this->state = SystemEventState::Uninitialized; this->state = SystemEventState::Uninitialized;
} }
@ -131,8 +130,7 @@ namespace sts::os {
this->GetInterProcessEvent().Signal(); this->GetInterProcessEvent().Signal();
break; break;
case SystemEventState::Uninitialized: case SystemEventState::Uninitialized:
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }
@ -145,8 +143,7 @@ namespace sts::os {
this->GetInterProcessEvent().Reset(); this->GetInterProcessEvent().Reset();
break; break;
case SystemEventState::Uninitialized: case SystemEventState::Uninitialized:
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }
void SystemEvent::Wait() { void SystemEvent::Wait() {
@ -158,8 +155,7 @@ namespace sts::os {
this->GetInterProcessEvent().Wait(); this->GetInterProcessEvent().Wait();
break; break;
case SystemEventState::Uninitialized: case SystemEventState::Uninitialized:
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }
@ -170,8 +166,7 @@ namespace sts::os {
case SystemEventState::InterProcessEvent: case SystemEventState::InterProcessEvent:
return this->GetInterProcessEvent().TryWait(); return this->GetInterProcessEvent().TryWait();
case SystemEventState::Uninitialized: case SystemEventState::Uninitialized:
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }
@ -182,8 +177,7 @@ namespace sts::os {
case SystemEventState::InterProcessEvent: case SystemEventState::InterProcessEvent:
return this->GetInterProcessEvent().TimedWait(ns); return this->GetInterProcessEvent().TimedWait(ns);
case SystemEventState::Uninitialized: case SystemEventState::Uninitialized:
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }
} }

View File

@ -48,8 +48,7 @@ namespace sts::os {
new (GetPointer(this->impl_storage)) impl::WaitableHolderOfInterProcessEvent(&event->GetInterProcessEvent()); new (GetPointer(this->impl_storage)) impl::WaitableHolderOfInterProcessEvent(&event->GetInterProcessEvent());
break; break;
case SystemEventState::Uninitialized: case SystemEventState::Uninitialized:
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
/* Set user-data. */ /* Set user-data. */
@ -81,8 +80,7 @@ namespace sts::os {
case MessageQueueWaitKind::ForNotEmpty: case MessageQueueWaitKind::ForNotEmpty:
new (GetPointer(this->impl_storage)) impl::WaitableHolderOfMessageQueueForNotEmpty(message_queue); new (GetPointer(this->impl_storage)) impl::WaitableHolderOfMessageQueueForNotEmpty(message_queue);
break; break;
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
/* Set user-data. */ /* Set user-data. */

View File

@ -70,8 +70,7 @@ namespace sts::spl {
case HardwareType::Hoag: case HardwareType::Hoag:
case HardwareType::Iowa: case HardwareType::Iowa:
return true; return true;
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }

View File

@ -72,8 +72,7 @@ namespace sts::updater {
return true; return true;
case BootImageUpdateType::Mariko: case BootImageUpdateType::Mariko:
return false; return false;
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }
@ -83,8 +82,7 @@ namespace sts::updater {
return true; return true;
case BootImageUpdateType::Mariko: case BootImageUpdateType::Mariko:
return false; return false;
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }
@ -94,8 +92,7 @@ namespace sts::updater {
return NcmContentMetaType_BootImagePackage; return NcmContentMetaType_BootImagePackage;
case BootModeType::Safe: case BootModeType::Safe:
return NcmContentMetaType_BootImagePackageSafe; return NcmContentMetaType_BootImagePackageSafe;
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }
@ -185,8 +182,7 @@ namespace sts::updater {
return VerifyBootImagesNormal(data_id, work_buffer, work_buffer_size, boot_image_update_type); return VerifyBootImagesNormal(data_id, work_buffer, work_buffer_size, boot_image_update_type);
case BootModeType::Safe: case BootModeType::Safe:
return VerifyBootImagesSafe(data_id, work_buffer, work_buffer_size, boot_image_update_type); return VerifyBootImagesSafe(data_id, work_buffer, work_buffer_size, boot_image_update_type);
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }
@ -311,8 +307,7 @@ namespace sts::updater {
return UpdateBootImagesNormal(data_id, work_buffer, work_buffer_size, boot_image_update_type); return UpdateBootImagesNormal(data_id, work_buffer, work_buffer_size, boot_image_update_type);
case BootModeType::Safe: case BootModeType::Safe:
return UpdateBootImagesSafe(data_id, work_buffer, work_buffer_size, boot_image_update_type); return UpdateBootImagesSafe(data_id, work_buffer, work_buffer_size, boot_image_update_type);
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }
@ -505,8 +500,7 @@ namespace sts::updater {
case spl::HardwareType::Hoag: case spl::HardwareType::Hoag:
case spl::HardwareType::Iowa: case spl::HardwareType::Iowa:
return BootImageUpdateType::Mariko; return BootImageUpdateType::Mariko;
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }

View File

@ -130,12 +130,16 @@ namespace sts::updater {
PartitionAccessor(FsBisStorageId id) : BisAccessor(id) { } PartitionAccessor(FsBisStorageId id) : BisAccessor(id) { }
private: private:
constexpr const OffsetSizeType *FindEntry(EnumType which) { constexpr const OffsetSizeType *FindEntry(EnumType which) {
const OffsetSizeType *entry = nullptr;
for (size_t i = 0; i < Meta::NumEntries; i++) { for (size_t i = 0; i < Meta::NumEntries; i++) {
if (Meta::Entries[i].which == which) { if (Meta::Entries[i].which == which) {
return &Meta::Entries[i]; entry = &Meta::Entries[i];
break;
} }
} }
std::abort();
STS_ASSERT(entry != nullptr);
return entry;
} }
public: public:
Result Read(size_t *out_size, void *dst, size_t size, EnumType which) { Result Read(size_t *out_size, void *dst, size_t size, EnumType which) {
@ -194,8 +198,7 @@ namespace sts::updater {
return FsBisStorageId_BootConfigAndPackage2RepairMain; return FsBisStorageId_BootConfigAndPackage2RepairMain;
case Package2Type::RepairSub: case Package2Type::RepairSub:
return FsBisStorageId_BootConfigAndPackage2RepairSub; return FsBisStorageId_BootConfigAndPackage2RepairSub;
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }

View File

@ -72,8 +72,7 @@ namespace sts::updater {
constexpr const char *candidates[] = {BctPathA, BctPathNx}; constexpr const char *candidates[] = {BctPathA, BctPathNx};
return ChooseCandidatePath(candidates, util::size(candidates)); return ChooseCandidatePath(candidates, util::size(candidates));
} }
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }
@ -89,8 +88,7 @@ namespace sts::updater {
constexpr const char *candidates[] = {Package1PathA, Package1PathNx}; constexpr const char *candidates[] = {Package1PathA, Package1PathNx};
return ChooseCandidatePath(candidates, util::size(candidates)); return ChooseCandidatePath(candidates, util::size(candidates));
} }
default: STS_UNREACHABLE_DEFAULT_CASE();
std::abort();
} }
} }
@ -106,8 +104,7 @@ namespace sts::updater {
constexpr const char *candidates[] = {Package2PathA, Package2PathNx}; constexpr const char *candidates[] = {Package2PathA, Package2PathNx};
return ChooseCandidatePath(candidates, util::size(candidates)); return ChooseCandidatePath(candidates, util::size(candidates));
} }
default: STS_UNREACHABLE_DEFAULT_CASE();;
std::abort();
} }
} }